Bump Scala to version 2.13 and scalatest to version 3.2.10
#712
Conversation
- This is from `2.12` -> `2.13` - Adds `import scala.language.postfixOps` where needed - Changes test generation for new version of `scalatest`
- This is a change in each `exercise/**/build.sbt`
|
looking at the maintainer tracker found here I'm going to assume that @ErikSchierboom or @iHiD could potentially help me complete this PR or point me in the right direction. |
|
Thanks a lot!
I don't think that was necessary. In fact, could you perhaps remove that commit from this PR and open a separate PR for the syncing update? The update is much appreciated, but we prefer to have PRs do just a single thing.
We currently don't have any active Scala maintainers. What I would do is to just ignore the generators now and only update the exercises. |
- adds missing newlines for `exercises/**/build.sbt` - imports play-json correctly in `build.sbt`
- `scalatest` is no longer monolithic, specific things must be imported - `FunSuite` renamed to `AnyFunSuite` - `FlatSpec` renamed to `AnyFlatSpec` - `Matchers` used throughout were moved and refactored, these tests use `org.scalatest.matchers.should.Matchers` See the [ScalaTest 3.2.0 release notes](https://www.scalatest.org/release_notes/3.2.0) for details on what was deprecated.
|
I removed the I think another PR to update track requirements in the documentation might be needed, or that might be in scope for this PR. Let me know. |
Perfect.
Yes, I think it makes sense to include it in this PR, as it is a related change. |
- Added callout to use SDKMAN - Updated JDK Requirement to be JDK 11 - Updated sbt and Scala requirements
|
No worries, added my two cents to |
|
Merged! Thanks a lot. |
|
@CJSmith-0141 BTW, did you intend to try and upgrade to Scala 3 too? |
|
For my day job we're waiting for some of the more of the libraries we use to update to Scala 3 before we make the plunge. That being said, if Exercism's appetite is to stay cutting edge I would be happy to take a crack at it. |
|
Well, we don't really use many libraries. I guess we could maybe do an inventory of the libraries we use, but I expect it's very limited. So yes: I think trying to upgrade to Scala 3 makes sense for us! |
- removes `scala-parser-combinators` from `matching-brackets/build.sbt` - bug introduced by [PR#712](exercism#712)
- removes `scala-parser-combinators` from exercises that did not need them - bumps `scala-parser-combinators` to version `2.1.0` for `sgf-parsing` exercise - bug introduced by [PR#712](exercism#712)
- removes `scala-parser-combinators` from exercises that did not need them - bumps `scala-parser-combinators` to version `2.1.0` for `sgf-parsing` exercise - bug introduced by [PR#712](exercism#712)
Addresses #678 and partially addresses #684
I also ran
configlet sync -u, not sure if that was needed or necessary.I was not able to get the generation code to work, could someone help bring that home? It might need a re-write.
Help needed on the test generation. Manually editing the tests with these changes works.