Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 support #55

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

grzegorz-bielski
Copy link
Contributor

@grzegorz-bielski grzegorz-bielski commented Jul 14, 2024

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 14, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

@grzegorz-bielski grzegorz-bielski marked this pull request as ready for review July 24, 2024 09:09
@grzegorz-bielski grzegorz-bielski requested a review from a team as a code owner July 24, 2024 09:09
@ErikSchierboom
Copy link
Member

Great work! We'll need to synchronize the merging of this PR with the merging of the other PR.

@ErikSchierboom
Copy link
Member

@grzegorz-bielski When would be a good time for you to merge both PRs?

@grzegorz-bielski
Copy link
Contributor Author

@ErikSchierboom For me they could be merged at any moment, but I believe I lack proper permissions to do so.

@ErikSchierboom
Copy link
Member

Okay, I'll do it tomorrow morning!

@ErikSchierboom ErikSchierboom merged commit fc1284e into exercism:main Aug 14, 2024
1 check passed
@ErikSchierboom ErikSchierboom added x:rep/large Large amount of reputation and removed x:rep/large Large amount of reputation labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants