-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from JavaScript to TypeScript #66
base: main
Are you sure you want to change the base?
Conversation
Oh, awesome! Thank you so much for all that work 💙 I should have some time on the weekend to review this PR in detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a whole bunch of comments with feedback. I think there is some chaos in the type definitions and how they're used, and there's too much usage of as ...
in the source code (not it tests, in tests in takes sense).
If you have more time to work on this PR, I would be happy to receive changes for my feedback, but if you don't have time anymore, I can also make those changes myself. Let me know!
I didn't test yet if the library still works after the changes. I would only do that later, at the end of the review process when I expect no more changes to be made to the source code (so that I don't have to test this more than once, it's a slow and manual process).
Thanks for the feedback. I'll work on your comments in the next few days and revert. |
Hi @angelikatyborska 👋🏾 ready for another review |
Thank you for the changes 🙏 I currently don't have time for open-source work, but this should change in a few weeks. Your contributions are appreciated and I WILL review them, just not right now. Sorry about that! |
Addressing #9