Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol change to https style (And some markdown style updates) #636

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Protocol change to https style (And some markdown style updates) #636

merged 2 commits into from
Jun 28, 2024

Conversation

kotp
Copy link
Member

@kotp kotp commented Jun 27, 2024 •
edited
Loading

First commit is for style consistency, second is actual helpful update
to link.

  • Style consistency
  • URI Protocol Changes

@kotp
Style consistency
ab500bc 
- Blank line after heading
- EOL at last line
- Trailing whitespace reserved for semantic use
@kotp
Copy link
Member Author

kotp commented Jun 27, 2024

It looks like the broken link was temporary, as it is working today.

Let me know if you still want the first patch.

Bajger
Bajger requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@Bajger Bajger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made few suggestions. Anyway, thanks for your contribution!

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/LEARNING.md Outdated Show resolved Hide resolved
docs/LEARNING.md Outdated Show resolved Hide resolved
docs/LEARNING.md Outdated Show resolved Hide resolved
docs/LEARNING.md Outdated Show resolved Hide resolved
docs/RESOURCES.md Outdated Show resolved Hide resolved
docs/RESOURCES.md Outdated Show resolved Hide resolved
docs/RESOURCES.md Outdated Show resolved Hide resolved
docs/RESOURCES.md Outdated Show resolved Hide resolved
docs/RESOURCES.md Show resolved Hide resolved
@Bajger
Copy link
Contributor

Bajger commented Jun 28, 2024

@kotp Hi Victor! I guess you could use also link to Inria site resource: https://rmod-files.lille.inria.fr/FreeBooks/WithStyle/SmalltalkWithStyle.pdf, but I'm not sure, which one is more reliable (probably webarchive)?

@kotp kotp force-pushed the wayback_smalltalk_with_style branch from 775a66d to 8179210 Compare June 28, 2024 06:58
@kotp kotp force-pushed the wayback_smalltalk_with_style branch from 8179210 to a20802d Compare June 28, 2024 07:01
@kotp
Copy link
Member Author

kotp commented Jun 28, 2024

@kotp Hi Victor! I guess you could use also link to Inria site resource: https://rmod-files.lille.inria.fr/FreeBooks/WithStyle/SmalltalkWithStyle.pdf, but I'm not sure, which one is more reliable (probably webarchive)?

I suppose I could, but would rather link to the live version if it is stable, since any updates the author would wish to make we would gain the benefit of.

The updated link has been restored, but the http secure protocol has been updated for pharo.org links.

@kotp kotp requested a review from Bajger June 28, 2024 07:07
@kotp kotp changed the title Wayback link for Smalltalk with style pdf Protocol change to https style (And some markdown style updates) Jun 28, 2024
@Bajger Bajger merged commit 4afa33f into exercism:main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bajger Bajger Bajger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kotp @Bajger