Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add circular buffer exercise #584

Merged
merged 9 commits into from
Sep 10, 2023
Merged

Add circular buffer exercise #584

merged 9 commits into from
Sep 10, 2023

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Sep 8, 2023

Added circular buffer exercise including solution.

@Bajger
Copy link
Contributor Author

Bajger commented Sep 8, 2023

@glennj I have some trouble with configlet lint, with UUID - obviously Pharo generator (by: UUIDGenerator next) does not produce in format that is needed for linter. Will find out, how it can be fixed (worst case I will overwrite it manually).
Other than that, you can review tests and solution for circular buffer. Hope it is Pharo idiomatic way.

@Bajger Bajger added review code review required exercise This issue concerns an exercise x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) labels Sep 8, 2023
@Bajger
Copy link
Contributor Author

Bajger commented Sep 8, 2023

CI green! @ErikSchierboom can approve now.

glennj
glennj approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@glennj glennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

ErikSchierboom
ErikSchierboom approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Bajger Bajger merged commit bf19afd into exercism:main Sep 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@glennj glennj glennj approved these changes

Assignees
No one assigned
Labels
exercise This issue concerns an exercise review code review required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bajger @glennj @ErikSchierboom