Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fetch-configlet script to all tracks #267

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Sync fetch-configlet script to all tracks #267

merged 1 commit into from
Nov 17, 2022

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom temporarily deployed to abort-timer November 17, 2022 11:41 Inactive
ee7
ee7 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the fetch-configlet scripts on tracks:

  • Print success message
  • Make some variables local
  • Support new configlet release naming scheme

Upstream commits:

@ErikSchierboom ErikSchierboom marked this pull request as ready for review November 17, 2022 13:20
@ErikSchierboom ErikSchierboom requested a review from a team as a code owner November 17, 2022 13:20
@ErikSchierboom ErikSchierboom merged commit ceface8 into main Nov 17, 2022
@ErikSchierboom ErikSchierboom deleted the sync-fetch-configlet branch November 17, 2022 13:20
@ee7
Copy link
Member

ee7 commented Nov 30, 2022

Closes: #262

@ee7 ee7 mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 approved these changes

@kytrinyx kytrinyx kytrinyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @ee7 @kytrinyx