-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exercises(secret-handshake): overhaul to use enum #537
Merged
Commits on Sep 23, 2023
-
exercises(secret-handshake): overhaul to use enum
This exercise has always [1] required the user to return seq[string], but the scenario is better modelled with an enum. This commit is similar to previous overhauls for the allergies [2] and space-age [3] exercises. Closes: exercism#536 [1] 8015636, 2019-02-24, "Adds secret-handshake exercise" [2] a8ab9c8, 2023-01-11, "exercises(allergies): overhaul to use enum" [3] b770d96, 2023-01-11, "exercises(space-age): overhaul to use enum"
Configuration menu - View commit details
-
Copy full SHA for 07098a6 - Browse repository at this point
Copy the full SHA 07098a6View commit details
Commits on Oct 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2ca6e38 - Browse repository at this point
Copy the full SHA 2ca6e38View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9bc7a5 - Browse repository at this point
Copy the full SHA e9bc7a5View commit details
Commits on Oct 2, 2023
-
exercises(secret-handshake): example: use testBit
Similar to previous discussions [1] I probably have a small preference for using shifts here, but it's fine either way. Note that bitops2 calls this `getBit` [2]. [1] exercism#434 (comment) [2] https://github.com/status-im/nim-stew/blob/3159137d9a31/stew/bitops2.nim#L420-L424 Suggested-by: ynfle
Configuration menu - View commit details
-
Copy full SHA for 85a6245 - Browse repository at this point
Copy the full SHA 85a6245View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0b582c - Browse repository at this point
Copy the full SHA b0b582cView commit details -
exercises(secret-handshake): example: DRY enum vals
This better supports adding new enum values, as long as those values aren't "special" like Reverse.
Configuration menu - View commit details
-
Copy full SHA for e0a53ef - Browse repository at this point
Copy the full SHA e0a53efView commit details -
Configuration menu - View commit details
-
Copy full SHA for eebf075 - Browse repository at this point
Copy the full SHA eebf075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a08b71 - Browse repository at this point
Copy the full SHA 0a08b71View commit details -
exercises(secret-handshake): example: write result first
For symmetry with the branch above.
Configuration menu - View commit details
-
Copy full SHA for 94fc7d3 - Browse repository at this point
Copy the full SHA 94fc7d3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.