-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Nucleotide Count (resolves #161) #166
feat: Add Nucleotide Count (resolves #161) #166
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
li $v0, 4 | ||
syscall | ||
|
||
lw $a0, 0($s5) # print actual A that failed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 112..126 and 132..146 could be extracted into a subroutine, with $s5 or $s2 passed as an argument, perhaps using $a2.
We could print "[1, 2, 3, 4]"
instead of the current "1234"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like 1234 is fine for now, but feel free to change it if you like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. The all-your-base runner will also have a subroutine, to print lists like "[6, 10, 45]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you want to change that printing bit or if you're happy with this being merged
li $v0, 4 | ||
syscall | ||
|
||
lw $a0, 0($s5) # print actual A that failed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like 1234 is fine for now, but feel free to change it if you like
Note the Luhn exercise is also ready for review: #169 |
4595b10
to
8b41e17
Compare
No description provided.