Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructured Gradle projects #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErwinOlie
Copy link
Contributor

  • moved the autotest-runner project inside /lib/
  • introduced single root project with many subprojects
  • centralized the settings.gradle.kts and Gradle wrapper files

besides only having to maintain a single Gradle root projects, this opens up the posibility to use version catalogs and fixes IntelliJ syntax highlighting of the .kts files.

@ErwinOlie ErwinOlie requested a review from a team as a code owner November 4, 2023 00:11
Copy link

github-actions bot commented Nov 4, 2023

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 4, 2023
@ErwinOlie
Copy link
Contributor Author

@ErikSchierboom ready for review

@ErwinOlie ErwinOlie changed the title restructured Gradle project structure restructured Gradle projects Nov 4, 2023
@ErikSchierboom ErikSchierboom reopened this Nov 6, 2023
@ErikSchierboom
Copy link
Member

I'll review tomorrow

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure you want to delete the gradle files from the examples. They will be there when the test runner processes a submitted solution. That said, I don't think the test runner uses them, as we're using Maven to run the tests. So it might be fine. Just something to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants