Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordy: add topics for exercise to config.json per #850 #865

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

ilya-khadykin
Copy link
Contributor

Fixes #850


Reviewer Resources:

Track Policies

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @m-a-ge! :) I've suggested a few more topics but feel free to disagree with me :)

config.json Outdated
"strings",
"parsing",
"pattern_matching",
"transforming"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestions! :) I would maybe add logic and integers as well. And maybe regular_expressions? What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also exception_handling since the tests expect an exception to be thrown :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, I'll update the PR shortly

@ilya-khadykin
Copy link
Contributor Author

@FridaTveit I've updated PR based on your suggestions

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @m-a-ge! :)

@FridaTveit FridaTveit merged commit 220c510 into exercism:master Oct 6, 2017
@ilya-khadykin ilya-khadykin deleted the issue#850 branch October 6, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants