list-ops: add hint of using static methods per #378 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FridaTveit
reviewed
Oct 5, 2017
exercises/list-ops/.meta/hints.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## Hints | |||
|
|
|||
| In Java it's a best pracite to use instance methods over class methods. However, there are conditions in which it is absolutely appropriate for a function to be `static`. Since classes in Java are closed for modification (i.e. you cannot add members to a class outside its definition like you can in other languages like Ruby or JavaScript), you cannot add new behavior to the class, directly. What to do if you still want to define behavior for a given type? The idiomatic solution in this case is to write a utility method. | |||
There was a problem hiding this comment.
Should be "practice" :) And I don't think there should be a comma before "directly"? I'm not an expert on comma usage though so feel free to tell me if I'm wrong :P
There was a problem hiding this comment.
Also I think it should be "it's considered best practice" instead of "it's a best practice". What do you think?
There was a problem hiding this comment.
@FridaTveit you are right, I'll fix those later today.
Thanks for pointing out 👍
ilya-khadykin
force-pushed
the
issue#378
branch
from
47c8659 to
aa82ee2
Compare
|
@FridaTveit I've corrected those annoying mistakes |
FridaTveit
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #378
Reviewer Resources:
Track Policies