twelve-days: create and validate starter implementation #683
Conversation
| public String verse(int verseNumber) { | ||
| throw new UnsupportedOperationException("Delete this statement and provide your own implementation."); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please indent with 4 spaces for consistency.
| @@ -120,18 +120,21 @@ public void testVerseTwelve() { | |||
| @Ignore("Remove to run test") | |||
| @Test | |||
| public void testMultipleVerses() { | |||
| /* | |||
There was a problem hiding this comment.
The more I think about this strategy, the more convinced I am that the net effect is more confusing than useful. I think that's because:
- only a few exercises require more than one method;
- that tests are commented out is potentially really non-obvious to users.
IMO it would be simpler to say: full API stubs for exercises 1-20: no stubs or class only stubs for exercises 21+ (with exceptions for really tricky signatures as in list-ops).
Thoughts, @FridaTveit @Smarticles101?
There was a problem hiding this comment.
I was thinking the same thing when reading the policies doc.
There was a problem hiding this comment.
Awesome; in light of that consensus, please update this PR to include stubs of both methods and no commented-out tests; I'll update the policies doc right now.
|
Note: if you use slightly different language when referencing an issue from within a PR, you can have the issue auto-close when that PR is merged! |
| public String verses(int startVerse, int endVerse) { | ||
| throw new UnsupportedOperationException("Delete this statement and write your own implementation."); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please remove the public keyword from the class and method signatures here; last change request, promise!
There was a problem hiding this comment.
I'll update the POLICIES doc again to capture this.
- Classes as a whole removed, not just method/constructor stubs - Commenting out tests undone per discussion, exercism#683 - Enum 'Plant' re-added to Kindergarten Garden per discussion - .keep added to empty source folders
- Classes as a whole removed, not just method/constructor stubs - Commenting out tests undone per discussion, exercism#683 - Enum 'Plant' re-added to Kindergarten Garden per discussion - .keep added to empty source folders
As this is exercise 20, I only provided a stub for the verse method as it was the only method used in the first test case, and I commented out the two test cases that use the verses method.
Resolves #551
Reviewer Resources:
Track Policies