rna-transcription: rename "ofDna" with "transcribe" #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtigger
reviewed
May 9, 2017
There was a problem hiding this comment.
Thanks for taking this on @Smarticles101!
Now that I'm looking at it, I wonder if we could do something similar for that method's parameter. dnaString is a start, but I feel like we could go deeper into the domain (and be a good hint/nudge to practitioners to do the same).
What is this thing coming in? Is dna enough? Is it a dnaStrand?
Of course, this is expanding the scope of the original ticket. You are perfectly in your rights to say, "how about we tackle that in another PR?" :)
|
@jtigger I think that the issue you mentioned is well related to this PR. I think it would be great to rename it to |
FridaTveit
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #455
Also renamed input string to
dnaStrand