Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #420 #430

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fixes #420 #430

merged 1 commit into from
Apr 20, 2017

Conversation

ajayboseac
Copy link
Contributor

nth-prime: simplify example implementation

nth-prime: simplify example implementation
@ajayboseac
Copy link
Contributor Author

I am not able to figure out why the CI checks are failing. Can someone help ?

@FridaTveit
Copy link
Contributor

Sorry, I'm not sure either. I tried restarting it but that didn't help. @jtigger @stkent any ideas?

@stkent
Copy link
Contributor

stkent commented Apr 20, 2017

No idea, sorry!

@jtigger
Copy link
Contributor

jtigger commented Apr 20, 2017

On it.

@jtigger
Copy link
Contributor

jtigger commented Apr 20, 2017

gak. Not sure of the root cause, but I see that the latest version of Trackler is not playing well with the corresponding version of x-api. I'm still digging...

@jtigger
Copy link
Contributor

jtigger commented Apr 20, 2017

Found it... I'll submit a PR and explain there what the defect was.

@jtigger
Copy link
Contributor

jtigger commented Apr 20, 2017

See #431 for details. I'll keep an eye on it.

@jtigger
Copy link
Contributor

jtigger commented Apr 20, 2017

I didn't see this PR's build automatically kick. I wonder if that had anything to do with the fact that it's based of master and not a separate branch. Does anyone know the deets on how that works in GitHub?

p.s. I manually rekicked the build, hoping it would incorporate #431.

@stkent
Copy link
Contributor

stkent commented Apr 20, 2017

Thanks, @jtigger!

And thanks, @ajayboseac, change looks great; merging!

@stkent stkent merged commit f64a37a into exercism:master Apr 20, 2017
@ajayboseac
Copy link
Contributor Author

Thanks @jtigger and @stkent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants