Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pascals-triangle: update to v1.0.0 tests #424

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

stkent
Copy link
Contributor

@stkent stkent commented Apr 14, 2017

Closes #365.

Updates the exercise to match the most current canonical data at the time of implementation.

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

@@ -0,0 +1,21 @@
class TriangleGenerator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe PascalsTriangleGenerator would make it more obvious what the class is for?

@stkent stkent force-pushed the 365-pascals-triangle-overhaul branch from 7af5bb3 to 4024f15 Compare April 15, 2017 15:55
@stkent
Copy link
Contributor Author

stkent commented Apr 15, 2017

@FridaTveit updated!

@FridaTveit FridaTveit merged commit f973d33 into master Apr 17, 2017
@stkent stkent deleted the 365-pascals-triangle-overhaul branch April 18, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants