prime-factors: convert to use instance methods #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkent
commented
Apr 5, 2017
| @@ -1,5 +1,4 @@ | |||
| import org.junit.Test; | |||
| import org.junit.Ignore; | |||
There was a problem hiding this comment.
Unused due to test suite parametrization.
stkent
commented
Apr 5, 2017
| {3L, Arrays.asList(3L)}, | ||
| {1L, emptyList()}, | ||
| {2L, singletonList(2L)}, | ||
| {3L, singletonList(3L)}, |
There was a problem hiding this comment.
All suggestions from IntelliJ.
There was a problem hiding this comment.
I'm more used to seeing this as Collections.emptyList() and Collections.singletonList() without the static import. That might make it more clear to someone who hasn't encountered them before?
FridaTveit
approved these changes
Apr 6, 2017
| {3L, Arrays.asList(3L)}, | ||
| {1L, emptyList()}, | ||
| {2L, singletonList(2L)}, | ||
| {3L, singletonList(3L)}, |
There was a problem hiding this comment.
I'm more used to seeing this as Collections.emptyList() and Collections.singletonList() without the static import. That might make it more clear to someone who hasn't encountered them before?
stkent
force-pushed
the
363-prime-factors-instance-method
branch
from
90712de to
e3c19cf
Compare
FridaTveit
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363.