Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rna-transcription: make object-based and add starter implementation #334

Merged
merged 3 commits into from
Mar 6, 2017

Conversation

FridaTveit
Copy link
Contributor

Changed rna-transcription to have an object based implementation (see issue #177) and added starter implementation as it is currently the second exercise in the new ordering (see issue #178).

Complete started implementation added as this is currently the second
exercise in the new ordering.

See issue exercism#178
@stkent
Copy link
Contributor

stkent commented Mar 3, 2017

Looks good! I'm not sure whether I prefer returning null vs throwing an unimplemented exception in the stubbed implementation - I feel like null could in general lead to a confusing error message when the tests are first run, and that the thrown exception route gives us more control over that messaging and experience. What do you think, Frida? I don't feel particularly strongly either way so I'm happy to go with whatever you decide, just let me know :)

@stkent stkent self-assigned this Mar 3, 2017
@FridaTveit
Copy link
Contributor Author

I didn't think about that, thanks for mentioning it! :) An exception is probably better. Do you think UnsupportedOperationException with message "Method has not been implemented yet" would be okay?

@stkent
Copy link
Contributor

stkent commented Mar 3, 2017

@FridaTveit that exception type sounds good to me, and to others!

@stkent stkent merged commit bbfaa4c into exercism:master Mar 6, 2017
@stkent
Copy link
Contributor

stkent commented Mar 6, 2017

Thanks, @FridaTveit!

@FridaTveit FridaTveit deleted the RnaTranscriptionChangeToObject branch October 17, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants