Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sets concept #2769

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Add sets concept #2769

merged 9 commits into from
Apr 4, 2024

Conversation

sanderploegsma
Copy link
Contributor

@sanderploegsma sanderploegsma commented Apr 2, 2024 •
edited
Loading

This PR adds the sets concept, together with the concept exercise gotta-snatch-em-all, forked from the Elm track.

Fixes #2557

Reviewer Resources:

Track Policies

@sanderploegsma sanderploegsma self-assigned this Apr 2, 2024
@sanderploegsma sanderploegsma added the x:size/large Large amount of work label Apr 3, 2024
@sanderploegsma sanderploegsma marked this pull request as ready for review April 3, 2024 12:48
@sanderploegsma sanderploegsma requested a review from kahgoh April 3, 2024 18:00
@sanderploegsma
Copy link
Contributor Author

@manumafe98 Thanks 🙈

@manumafe98
Copy link
Contributor

@sanderploegsma I love the creativity of this exercise 😆

@sanderploegsma
Copy link
Contributor Author

Yes so do I, which is why I initially picked it out while looking for concept exercises on sets in other tracks 😄

kahgoh
kahgoh reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Just picked up one minor grammar error in the instructions.

exercises/concept/gotta-snatch-em-all/.docs/instructions.md Outdated Show resolved Hide resolved
@sanderploegsma
Copy link
Contributor Author

@kahgoh Thanks for reviewing!

@sanderploegsma sanderploegsma merged commit ebfb3ed into main Apr 4, 2024
5 checks passed
@sanderploegsma sanderploegsma deleted the add-concept-sets branch April 4, 2024 04:27
@sanderploegsma sanderploegsma mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manumafe98 manumafe98 manumafe98 approved these changes

@kahgoh kahgoh kahgoh left review comments

Assignees

@sanderploegsma sanderploegsma

Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add concept: sets
3 participants
@sanderploegsma @manumafe98 @kahgoh