Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding analyzer feedback for captains-log concept exercise #2755

Merged

Conversation

manumafe98
Copy link
Contributor

pull request

closes #2674

Reviewer Resources:

Track Policies

@manumafe98 manumafe98 added the x:size/small Small amount of work label Mar 22, 2024
@manumafe98 manumafe98 self-assigned this Mar 22, 2024
@sanderploegsma
Copy link
Contributor

I've been going through the community solutions and these solutions stood out to me:

Solution Observations
Link Hard-coding the number of planet classes (10) instead of using the length of the array, could be an actionable comment.
Link This solution uses a Java version >= 17, judging by the usage of the RandomGenerator.nextDouble(double) method added in Java 17. However, those Java versions also contain RandomGenerator.nextDouble(double,double) and RandomGenerator.nextInt(int,int) which support passing both a lower and upper bound, which makes the solution a bit easier to read. Could be an informative comment.

@manumafe98
Copy link
Contributor Author

I've been going through the community solutions and these solutions stood out to me:

Solution Observations
Link Hard-coding the number of planet classes (10) instead of using the length of the array, could be an actionable comment.
Link This solution uses a Java version >= 17, judging by the usage of the RandomGenerator.nextDouble(double) method added in Java 17. However, those Java versions also contain RandomGenerator.nextDouble(double,double) and RandomGenerator.nextInt(int,int) which support passing both a lower and upper bound, which makes the solution a bit easier to read. Could be an informative comment.

I liked that options, seems that they are more appropriate and can actually help the student!

…, int) to only be taking into account if the user has java version 17 or higher
@manumafe98 manumafe98 merged commit 2fbf89f into exercism:main Apr 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

captains-log: describe Analyzer feedback in .meta/design.md
2 participants