Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding analyzer feedback to design.md for bird watcher concept exercise #2695

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Adding analyzer feedback to design.md for bird watcher concept exercise #2695

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffaccd
Adding analyzer feedback to design.md for bird watcher concept exercise
manumafe98 Jan 31, 2024
1a13926
Applying suggestions
manumafe98 Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions exercises/concept/bird-watcher/.meta/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,13 @@ This exercise's prerequisites Concepts are:
- `classes`: know how to work with fields.
- `booleans`: know what a `boolean` is.
- `basics`: know how to work with `integers` and how to assign and update variables.

## Analyzer

This exercise could benefit from the following rules in the [analyzer]:

- `essential`: Verify that the solution does not hard-code the arrays used by the tests (`{2, 5, 0, 7, 4, 1 }`, `{0, 2, 5, 3, 7, 8, 4}`)
- `actionable`: If the student did not use `clone` in the constructor to make a copy of the array, instruct them to do so.
sanderploegsma marked this conversation as resolved.
Show resolved Hide resolved
- `informative`: If the student used a different loop than a `For-Each` one in the methods `hasDayWithoutBirds` and `getBusyDays`, inform them that the solution can be improve using it.
sanderploegsma marked this conversation as resolved.
Show resolved Hide resolved

manumafe98 marked this conversation as resolved.
Show resolved Hide resolved
[analyzer]: https://github.com/exercism/java-analyzer