Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding analyzer feedback to design.md for log levels concept exercise #2694

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Adding analyzer feedback to design.md for log levels concept exercise #2694

merged 5 commits into from
Jan 31, 2024

Conversation

manumafe98
Copy link
Contributor

pull request

Related issue: #2680

Reviewer Resources:

Track Policies

@manumafe98 manumafe98 self-assigned this Jan 31, 2024
@manumafe98 manumafe98 added the x:size/small Small amount of work label Jan 31, 2024
@manumafe98
Copy link
Contributor Author

I guess after reading this guide that maybe the String.format part should be informative instead of actionable

@manumafe98
Updating analyzer information
5cddff6 
Adding celebratory comment
Modifying string.format to be informative instead of actionable
@manumafe98 manumafe98 merged commit e6fa002 into exercism:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahgoh kahgoh kahgoh left review comments

@sanderploegsma sanderploegsma sanderploegsma approved these changes

Assignees

@manumafe98 manumafe98

Labels
x:size/small Small amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manumafe98 @kahgoh @sanderploegsma