Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Squeaky Clean #2664

Merged

Conversation

manumafe98
Copy link
Contributor

Related issue: #2049

The goal of this PR is to update Squeaky clean to not ask the students to take into count control characters, unicode and greek letters.

Reviewer Resources:

Track Policies

Reformating exercise to not use unicode, control characters and greek letters
Updating docs and tests, and meta reference
@manumafe98
Copy link
Contributor Author

manumafe98 commented Jan 29, 2024

I was thinking after the reformat, are we falling short with this concept exercise? do we need to add another point so students understand better the concept? I was thinking on something to do if the string already contains an uppercase letter maybe.

@manumafe98
Copy link
Contributor Author

Also the pipeline seems to be failing because of the practice exercise strain which is weird

@sanderploegsma
Copy link
Contributor

I was thinking after the reformat, are we falling short with this concept exercise? do we need to add another point so students understand better the concept? I was thinking on something to do if the string already contains an uppercase letter maybe.

Well, the exercise is meant to introduce the concept. Right now it teaches letters, digits, punctuation and whitespace, which would be good enough of an introduction IMO.

Perhaps if you want to add another task we could make the digits part a bit more interesting, since it's now grouped with converting whitespace. What about if we ask students to convert from leetspeak to normal text? So they would be required to change H3ll0 W0rld into Hello_World or something.

@manumafe98
Copy link
Contributor Author

Perhaps if you want to add another task we could make the digits part a bit more interesting, since it's now grouped with converting whitespace. What about if we ask students to convert from leetspeak to normal text? So they would be required to change H3ll0 W0rld into Hello_World or something.

Uhh I really like this idea!! but also I think if we do this it should be with a couple of words, mostly the easy ones like

e = 3
a = 4
o = 0
l = 1
t = 7

and probably no more than that.

@sanderploegsma
Copy link
Contributor

Sounds good 👍

@manumafe98
Copy link
Contributor Author

I added the new task, I'm not sure if I should add a note that says that we are not using all the numbers from leetspeak or if the students should realize this checking the tests.

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look good!

@sanderploegsma
Copy link
Contributor

Also, since your changes to the exercise are substantial, feel free to add yourself as an author/contributor to the exercise's .meta/config.json 👍

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@manumafe98 manumafe98 merged commit 02d488e into exercism:main Jan 30, 2024
5 checks passed
@sanderploegsma
Copy link
Contributor

I just realized that we forgot to update the exercise's .meta/design.md file. We changed the scope of the exercise quite a bit and that should be reflected in the design file. Could you open another PR to address this?

@manumafe98
Copy link
Contributor Author

I just realized that we forgot to update the exercise's .meta/design.md file. We changed the scope of the exercise quite a bit and that should be reflected in the design file. Could you open another PR to address this?

Oh yeah, we totally forgot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants