-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Squeaky Clean #2664
Updating Squeaky Clean #2664
Conversation
Reformating exercise to not use unicode, control characters and greek letters Updating docs and tests, and meta reference
I was thinking after the reformat, are we falling short with this concept exercise? do we need to add another point so students understand better the concept? I was thinking on something to do if the string already contains an uppercase letter maybe. |
Also the pipeline seems to be failing because of the practice exercise |
Well, the exercise is meant to introduce the concept. Right now it teaches letters, digits, punctuation and whitespace, which would be good enough of an introduction IMO. Perhaps if you want to add another task we could make the digits part a bit more interesting, since it's now grouped with converting whitespace. What about if we ask students to convert from leetspeak to normal text? So they would be required to change |
Uhh I really like this idea!! but also I think if we do this it should be with a couple of words, mostly the easy ones like
and probably no more than that. |
Sounds good 👍 |
…thub.com/manumafe98/java into UpdateSqueakyCleanToOnlyIntroduceToChars
I added the new task, I'm not sure if I should add a note that says that we are not using all the numbers from leetspeak or if the students should realize this checking the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to look good!
exercises/concept/squeaky-clean/.meta/src/reference/java/SqueakyClean.java
Outdated
Show resolved
Hide resolved
exercises/concept/squeaky-clean/src/test/java/SqueakyCleanTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/squeaky-clean/src/test/java/SqueakyCleanTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/squeaky-clean/src/test/java/SqueakyCleanTest.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Sander Ploegsma <[email protected]>
Co-authored-by: Sander Ploegsma <[email protected]>
Also, since your changes to the exercise are substantial, feel free to add yourself as an author/contributor to the exercise's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I just realized that we forgot to update the exercise's |
Oh yeah, we totally forgot |
Related issue: #2049
The goal of this PR is to update Squeaky clean to not ask the students to take into count control characters, unicode and greek letters.
Reviewer Resources:
Track Policies