Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use assertj (#2147) #2510

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Update tests to use assertj (#2147) #2510

merged 5 commits into from
Oct 5, 2023

Conversation

pavanbaloju
Copy link
Contributor

@pavanbaloju pavanbaloju commented Oct 5, 2023 •
edited
Loading

pull request for (#2147 )

Hi @sanderploegsma, I have updated the following tests in this PR. Please review!

  1. CollatzCalculatorTest.java
  2. CryptoSquareTest.java
  3. DartsTest.java
  4. DifferenceOfSquaresCalculatorTest.java
  5. DiffieHellmanTest.java
  6. DnDCharacterTest.java
  7. DominoesTest.java
  8. ProteinTranslatorTest.java
  9. RotationalCipherTest.java

Reviewer Resources:

Track Policies

sanderploegsma
sanderploegsma requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark to take care of, the rest of the changes look good to me!

exercises/practice/diffie-hellman/src/test/java/DiffieHellmanTest.java Outdated Show resolved Hide resolved
@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Oct 5, 2023
sanderploegsma
sanderploegsma approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for your contribution!

@pavanbaloju
Copy link
Contributor Author

Nice work, thanks for your contribution!

Thanks for the oppurtunity!

@sanderploegsma sanderploegsma merged commit edb5725 into exercism:main Oct 5, 2023
3 checks passed
@pavanbaloju pavanbaloju deleted the update-tests-to-assertj branch October 5, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderploegsma sanderploegsma sanderploegsma approved these changes

Assignees
No one assigned
Labels
x:size/small Small amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavanbaloju @sanderploegsma