Switch to assertj for exceptions #2502
Conversation
# Conflicts: # exercises/practice/error-handling/src/test/java/ErrorHandlingTest.java
|
It looks like this includes updates to |
|
The change is very tiny in the sense that I only make the imports explicit. I probably can rebase it but have to look up what that is and how it works. I am wondering whether that really is worth the hassle, though. |
|
Ah well the reason I mentioned it is because there are conflicts with the If rebasing is new for you it’s also fine if you just merge the |
# Conflicts: # exercises/practice/error-handling/src/test/java/ErrorHandlingTest.java
…e/exercism_java into switch-to-assertj-for-exceptions
|
@keszocze thanks for picking up all of these! I'd like to ask you to make additional updates in a different PR: updates to exercise tests trigger new test runs of submitted solutions on the Exercism infrastructure, so we try not to update too many at once at risk of overloading the servers. Plus, small and focused PRs make my job of reviewing them a bit more manageable 🙃 |
|
Sure can do that. Then I stop adding more to this PR. As all changes belong to a single issue, I thought that this was fine. I sure do not want to make your life unnecessarily complicated ;) |
exercises/practice/sgf-parsing/src/test/java/SgfParsingTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/sgf-parsing/src/test/java/SgfParsingTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sander Ploegsma <[email protected]>
Co-authored-by: Sander Ploegsma <[email protected]>
…e/exercism_java into switch-to-assertj-for-exceptions
pull request
Switching to AssertJ for the
exercises.
This request brings #2147 closer to being fully solved.
Reviewer Resources:
Track Policies