Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AssertJ for exceptions #2494

Merged

Conversation

keszocze
Copy link
Contributor

pull request

The changes of this PR make the ErrorHandlingTest exercise use AssertJ in the tests.

This is related to #2147. As this is my first pull request for Exercism, I only changed the assertions for a single test case. If this merge request is fine, I'd like to also update the missing exercises as well.


Reviewer Resources:

Track Policies

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left two small comments, if you could address those I'd be glad to merge.

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again for contributing 😃

@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Sep 27, 2023
@sanderploegsma sanderploegsma merged commit eeea1c3 into exercism:main Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants