Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert exception assertions to AssertJ in SeriestTest #2172

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Convert exception assertions to AssertJ in SeriestTest #2172

merged 3 commits into from
Oct 10, 2022

Conversation

kerolloz
Copy link
Contributor

pull request

related to #2147

Reviewer Resources:

Track Policies

andrerfcsantos
andrerfcsantos approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Ci was failing because the file had an unused import - I committed the fix for you.

@andrerfcsantos andrerfcsantos merged commit eb6da0b into exercism:main Oct 10, 2022
@kerolloz
Copy link
Contributor Author

Thank you @andrerfcsantos

@kerolloz kerolloz deleted the patch-1 branch October 11, 2022 20:26
@jennylia jennylia mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerfcsantos andrerfcsantos andrerfcsantos approved these changes

Assignees
No one assigned
Labels
x:rep/small Small amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerolloz @andrerfcsantos