Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert exception assertions to AssertJ in classes starting with 'A' and 'B'. #2156

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Convert exception assertions to AssertJ in classes starting with 'A' and 'B'. #2156

merged 1 commit into from
Sep 25, 2022

Conversation

danielmrcl
Copy link
Contributor

pull request

Convert assertThrows to assertThatExceptionOfType in classes starting with 'A' and 'B'.

Reviewer Resources:

Track Policies

@danielmrcl
Convert exception assertions to AssertJ in classes starting with 'A' …
0f35ac4 
…and 'B'.

- affine-cipher
- all-your-base
- alphametics
- bank-account
- binary-search
- bowling
@danielmrcl danielmrcl mentioned this pull request Aug 20, 2022
Closed
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andrerfcsantos
andrerfcsantos approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Sorry for the delay in reviewing the PR. The track is currently undermaintained and I was bit busy the last couple of weeks.

@andrerfcsantos
Copy link
Member

Closing and opening the PR just to force CI to run - seems to be stuck at the moment.

@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Sep 25, 2022
@andrerfcsantos andrerfcsantos merged commit 6b5ff49 into exercism:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerfcsantos andrerfcsantos andrerfcsantos approved these changes

Assignees
No one assigned
Labels
x:rep/small Small amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmrcl @andrerfcsantos