minesweeper: add to track #174
Conversation
stkent
changed the title
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@stkent this is really the only part of this method that makes me wish for refactoring. I find myself wondering if there's not some way to grab the entire subset of characters concerned and reduce them to a number without nested for loops and ifs.
Otherwise this PR is generally very nice work.
There was a problem hiding this comment.
Thanks @matthewmorgan! I'll think about a neater implementation for that heavily-nested portion of the code, and probably switch to an object-based implementation per discussion in #177.
|
@matthewmorgan updated this implementation; I don't see a neat way around manually looping to check the cells surrounding a target, but I've at least broken the calculation of the annotated board down into smaller chunks now. |
|
@stkent, fair enough. I asked because we did this exercise over a code kata lunch at work a few weeks back, and the nested loops always provoke discussion! If I think of anything myself I'll be sure to share it with you. |
Data from https://github.com/exercism/x-common/blob/master/exercises/minesweeper/canonical-data.json, plus some extra tests to validate input.
The long annotate method is kind of ugly, so I'm happy to refactor to non-static methods to make it easier to break apart. Input welcome :)