Ignore all but first test in hello-world #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new JUnit test category that lets us mark certain tests as not ready for execution. The test task in the individual project can then be configured to not run tests marked as `NotReady`. For the CI server builds, add a fullTest test task that simply runs tests as normal, and link it into the check task so it runs on builds. This is not perfect, as the class under test must still compile, so it must have at least the correct signatures of all the methods tested. Also, it may be worth finding a way to distribute the NotReady interface that doesn't require checking it into every project.
Initial POC of how to ignore all-but-first test
- in base build script, filter out @ignores so that maintainers can run the full test suites. - increase the verbosity of test logging to aide in seeing progress as tests are un@Ignored and solved. - revamped GETTING_STARTED.md to reflect new output. It is now a complete guide from start to finish with calls-to-action at the end of the instructions.
jtigger
force-pushed
the
ignore-all-but-first-test
branch
2 times, most recently
from
93b7188 to
ca33ebb
Compare
- in journey test, remove @ignores so that test runs exercise all tests. - increase the verbosity of test logging to aide in seeing progress as tests are un@Ignored and solved. - saving scripts used to make changes to all exercises. These are the start of a library of scripts making such changes easier. - make Gradle output more CI-friendly.
jtigger
force-pushed
the
ignore-all-but-first-test
branch
from
ca33ebb to
35adc66
Compare
sit
approved these changes
Sep 24, 2016
| @@ -0,0 +1,21 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
What are these scripts for? Just for developer use?
There was a problem hiding this comment.
Yes. They are not at all generalized, but will be. In the meantime, a starting point to build other scripts?
|
Thanks for the review @sit! Yeah, I thought that the added complexity in the maintainer build (which you only have to understand if you need to modify it, at this point) was worth the trade-off of removing the complexity for the exercism programmer. There are additional benefits. By turning up test logging, the ignored tests are mentioned, signalling to the programmer there's more to do. |
|
👍 Thanks @jtigger ! |
This was referenced Sep 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started with @sit's suggestion, but then tacked to use
@Ignoreand defined a copy with filter in the rootbuild.gradlethat removes these annotations in a maintainers' build.