Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update to resolver 20.11" #78

Merged
merged 1 commit into from
May 2, 2023
Merged

Revert "Update to resolver 20.11" #78

merged 1 commit into from
May 2, 2023

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented May 2, 2023

Reverts #72

@iHiD iHiD requested a review from a team as a code owner May 2, 2023 20:17
@iHiD iHiD merged commit 57e55b8 into main May 2, 2023
@iHiD
Copy link
Member Author

iHiD commented May 2, 2023

@ErikSchierboom Can you revert this revert tomorrow pls. This deploy caused the machines to run out of HDD space so I reverted it. Not anyone's fault (other than mine really) but reverting was the quickest solution. As a note, this image is huge though (5GB) compared to other that are like 200MB.

@MatthijsBlom
Copy link
Contributor

MatthijsBlom commented May 2, 2023

This revert broke all exercises on the Haskell track again.

I guess this could (largely) be fixed by reverting exercism/haskell#1158 as well, but seeing as this one will be reverted tomorrow it's probably not worth the hassle. I'll post a heads-up on the forum.

iHiD added a commit that referenced this pull request May 2, 2023
iHiD added a commit that referenced this pull request May 2, 2023
ErikSchierboom added a commit that referenced this pull request May 3, 2023
@ErikSchierboom
Copy link
Member

@MatthijsBlom Is there any way in which we can reduce the image size? In particular, we're running stack build --resolver lts-20.18 --no-terminal --test --no-run-tests beforehand to pre-compile/download any extra dependencies.

@MatthijsBlom
Copy link
Contributor

I hardly know anything about what an image is, or what the test runner even does. I'd need to read up / be explained.

However,

In particular, we're running stack build --resolver lts-20.18 --no-terminal --test --no-run-tests beforehand to pre-compile/download any extra dependencies.

Do I understand correctly that you are 'pre-compiling' the allowed dependencies every time?

@ErikSchierboom
Copy link
Member

No, we're precompiling them once when we build the image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants