Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affine cipher exercise #2787

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

KasimKaizer
Copy link

No description provided.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 23, 2024
@ErikSchierboom ErikSchierboom requested a review from a team April 23, 2024 13:04
The encryption function is:

```text
E(x) = (ai + b) mod m
Copy link
Member

@tehsphinx tehsphinx Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From mathematical notation this is weird. E(x) means that this is a function called E that depends on the variable x. But there is no x in the calculation. (a, b, m are mathematically considered constants here and don't need to be mentioned.)

I think it should be E(i) or i changed to x in the function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that would need to be fixed upstream, in the prob-specs repo.

The decryption function is:

```text
D(y) = (a^-1)(y - b) mod m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the notation is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants