-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added usage of subtests to difference-of-squares #2432
added usage of subtests to difference-of-squares #2432
Conversation
Dear eklatzerThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
if s := SquareOfSum(test.n); s != test.sqOfSum { | ||
t.Fatalf("SquareOfSum(%d) = %d, want %d", test.n, s, test.sqOfSum) | ||
} | ||
t.Run(strconv.Itoa(test.input), func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as in #2428, I think we could use a test description here and use it as the subtest name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added descriptions, what do you think about them?
Co-authored-by: André Santos <[email protected]>
One of #2098