-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new practice exercise: state-of-tic-tac-toe #2284
Conversation
Dear AbhilashJNThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this one! You even included the test generator, which is great.
For the practices
and prerequisites
keys, you can leave them as empty arrays. It's something we will fill out when we have a more finalized set of concepts for the track. You can see the related issue here: #1396
For the topics
and difficulty
keys, see the comments below.
Also left some other suggestions for other things, let me know what you think.
In addition to the comments I left, one thing I considered is whether it would be better to have a State
type as a return result instead of a string. The type could be something like this:
type State string
const (
Win State = "win"
Draw State = "draw"
Ongoing State = "ongoing"
)
We could include this in the stub or in a separate file. Let me know what you think about this too.
exercises/practice/state-of-tic-tac-toe/state_of_tic_tac_toe_test.go
Outdated
Show resolved
Hide resolved
exercises/practice/state-of-tic-tac-toe/state_of_tic_tac_toe_test.go
Outdated
Show resolved
Hide resolved
exercises/practice/state-of-tic-tac-toe/state_of_tic_tac_toe_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more changes.
After these changes, I'll do another pass over everything, but it's looking really good!
exercises/practice/state-of-tic-tac-toe/state_of_tic_tac_toe_test.go
Outdated
Show resolved
Hide resolved
🚀 |
Fixes #2170
Can you please let me know where I can find the appropriate values for the
practices
,prerequisites
,difficulty
andtopics
fields?