-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the test-cases from canonical-data.json to exercise diamond #2255
Conversation
….json (no \n at the end)
Dear eklatzerThank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Maybe also interesting for #605 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Reach out to me if this change should be reverted and a \n should be expected at the end.
Let's revert it from now. The change might have some merits, but it is a big change, since it will make all current solutions fail the tests. Let's discuss it separately. Feel free to create a new issue about this after reverting the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more suggestions
Co-authored-by: André Santos <[email protected]>
Co-authored-by: André Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Hey, I have done the following steps:
gen.go
tests.toml
using configletcases_test.go
using thegen.go
func TestDiamond
using this test-casesI additionally adjusted the existing tests, as they expected a
\n
at the end. Regarding to theinstructions.md
there should not be a new-line at the end, for example:Diamond for letter 'E':
Reach out to me if this change should be reverted and a
\n
should be expected at the end.Closes #2222