Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated expected results #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

axtens
Copy link
Member

@axtens axtens commented Feb 28, 2024

Regenerated the expected_results.json files. Is that going to work?

@axtens axtens requested a review from a team as a code owner February 28, 2024 14:52
@axtens
Copy link
Member Author

axtens commented Feb 28, 2024

However I just ran

bin/run-in-docker.sh all-fail tests/all-fail tests/all-fail

and it gave me the wrong results? How does that work?!?!

@axtens
Copy link
Member Author

axtens commented Feb 28, 2024

bugmagnet@bugmagnet-wasta:~/Dropbox/Projects/test-runners/euphoria-test-runner$ sudo bin/run-in-docker.sh all-fail tests/all-fail tests/all-fail
[+] Building 2.5s (10/10) FINISHED                                                                                                                                                                                                                                                                                                                                                                                                    docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                                                                                                                                                                                                            0.0s
 => => transferring dockerfile: 768B                                                                                                                                                                                                                                                                                                                                                                                                            0.0s
 => [internal] load metadata for docker.io/library/ubuntu:24.04                                                                                                                                                                                                                                                                                                                                                                                 2.3s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                                                                                                                                               0.0s
 => => transferring context: 230B                                                                                                                                                                                                                                                                                                                                                                                                               0.0s
 => [1/5] FROM docker.io/library/ubuntu:24.04@sha256:ff0b5139e774bb0dee9ca8b572b4d69eaec2795deb8dc47c8c829becd67de41e                                                                                                                                                                                                                                                                                                                           0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                                                                                                                                               0.0s
 => => transferring context: 4.09kB                                                                                                                                                                                                                                                                                                                                                                                                             0.0s
 => CACHED [2/5] RUN apt update && apt install -y curl                                                                                                                                                                                                                                                                                                                                                                                          0.0s
 => CACHED [3/5] RUN filename="euphoria-4.1.0-Linux-x64-57179171dbed.tar.gz" &&     curl -L -O "https://github.com/OpenEuphoria/euphoria/releases/download/4.1.0/${filename}" &&     tar -xzf "${filename}" -C /usr/local &&     cd /usr/local/bin &&     find "/usr/local/euphoria-4.1.0-Linux-x64/bin" -type f -executable -exec ln -s {} ; &&     eui --version                                                                              0.0s
 => CACHED [4/5] WORKDIR /opt/test-runner                                                                                                                                                                                                                                                                                                                                                                                                       0.0s
 => [5/5] COPY . .                                                                                                                                                                                                                                                                                                                                                                                                                              0.0s
 => exporting to image                                                                                                                                                                                                                                                                                                                                                                                                                          0.0s
 => => exporting layers                                                                                                                                                                                                                                                                                                                                                                                                                         0.0s
 => => writing image sha256:f1be6ab2a86216b164a3fd783fb3a9ba9204ee9de99bcb6a7b900cb35924ef24                                                                                                                                                                                                                                                                                                                                                    0.0s
 => => naming to docker.io/exercism/euphoria-test-runner                                                                                                                                                                                                                                                                                                                                                                                        0.0s

What's Next?
  1. Sign in to your Docker account → docker login
  2. View a summary of image vulnerabilities and recommendations → docker scout quickview
all-fail: testing...
  failed: year not divisible by 4 in common year, expected: FALSE but got: TRUE
  failed: year divisible by 100 but not by 3 is still not a leap year, expected: FALSE but got: TRUE
  failed: year divisible by 2, not divisible by 4 in common year, expected: FALSE but got: TRUE
  failed: year divisible by 200, not divisible by 400 in common year, expected: FALSE but got: TRUE
  failed: year divisible by 100, not divisible by 400 in common year, expected: FALSE but got: TRUE
  failed: year divisible by 4 and 5 is still a leap year, expected: TRUE but got: FALSE
  failed: year divisible by 4, not divisible by 100 in leap year, expected: TRUE but got: FALSE
  failed: year divisible by 400 is leap year, expected: TRUE but got: FALSE
  failed: year divisible by 400 but not by 125 is still a leap year, expected: TRUE but got: FALSE
  9 tests run, 0 passed, 9 failed, 0% success
/solution
/output
/output/results.json
all-fail: testing...all-fail: done

Where are the /solution and /output paths coming from?

@ErikSchierboom
Copy link
Member

From the mounts specified in run-in-docker.sh

@axtens
Copy link
Member Author

axtens commented Apr 18, 2024

Run bin/run-tests-in-docker.sh
/home/runner/work/_temp/c768d0ea-28f[1](https://github.com/exercism/euphoria-test-runner/actions/runs/8090276919/job/22107509032?pr=26#step:5:1)-4bdd-a522-d34604ffd5b5.sh: line 1: bin/run-tests-in-docker.sh: Permission denied
Error: Process completed with exit code 126.

Not sure what to do with this

@ErikSchierboom
Copy link
Member

Not sure what to do with this

This PR has changed the file permissions on the bin scripts: https://github.com/exercism/euphoria-test-runner/pull/26/files So you'll need to revert those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants