Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalizing multi-component modules and module aliases #44

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Normalizing multi-component modules and module aliases #44

merged 2 commits into from
Nov 13, 2021

Conversation

jiegillet
Copy link
Contributor

Closes #43 (first commit).
Closes #33.
Addresses the alias part of #40. I haven't done the import yet, this PR is big enough as it is.

I also slightly modified represent so that it's easier to test inputs with iex.

@jiegillet jiegillet added x:action/improve Improve existing functionality/content x:module/representer Work on Representers x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/large Large amount of work labels Nov 6, 2021
angelikatyborska
angelikatyborska approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

test_data/modules/input.ex
Two.three()

Five.Six.Seven.nine()
Eight.Seven.nine()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close to "why is six afraid of seven?" 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! Is it too late to change the test? lol

@angelikatyborska angelikatyborska merged commit bfa7e41 into main Nov 13, 2021
@angelikatyborska angelikatyborska deleted the jie-module-name branch November 13, 2021 17:00
@angelikatyborska angelikatyborska mentioned this pull request Apr 20, 2022
Open
This was referenced Jul 14, 2022
Merged
Open
Closed
@angelikatyborska angelikatyborska mentioned this pull request Mar 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelikatyborska angelikatyborska angelikatyborska approved these changes

@neenjaw neenjaw Awaiting requested review from neenjaw

Assignees
No one assigned
Labels
x:action/improve Improve existing functionality/content x:module/representer Work on Representers x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add _ to list of special variables Normalize module names with multiple parts
2 participants
@jiegillet @angelikatyborska