-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin CI to latest stable Dart 2.10
& prepare for NNBD
#276
Conversation
@Liklainy I just updated the fetch_configlet to hopefully address the exit code issue. Please update your master branch and then issue-270 onto master. Let's see if that fixes that |
@Liklainy Can you update the Install dependencies step to use I think that could resolve some of the errors due to dependencies not being null-safe. |
Since dart |
@Stargator, Should I squash commits? |
@Liklainy and @devkabiir I ran `dart pub outdated --mode=null-safety and got the following result. This was after upgrading the Given this result and that I had to manually change the sdk version constraint to Additionally, I had to set the versioning for the test: '>=1.15.8 <2.0.0'
yaml: '>=2.3.0 <4.0.0' So for the sake of a stable CI process, for now, I recommend dropping For me, that means we keep the matrix setup and can even keep the 2.10 and latest tags if @devkabiir wants. So we at least have it setup to add dev when we can. |
I agree.
Keep the matrix setup with only
Don't worry about that, I'd prefer to use |
2.10
& prepare for NNBD
@Liklainy I appreciate your patience and continued efforts towards this PR very much. 🚀 |
Current changes in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🚀.
PS: Thanks for the ping.
matrix
withlatest
anddev
tagsfail-fast
for nowCloses actions/toolkit#270