Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving from Travis to GitHub Actions #267

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Moving from Travis to GitHub Actions #267

merged 4 commits into from
Nov 25, 2020

Conversation

davidlutta
Copy link
Contributor

Closes: #264

Changes and implications

  • Added GitHub action to run tests on push or a pull request
  • Changing the testing badge in the README.md to reflect GitHub actions
  • Deleted the travis.yml file

Future recommendation

  • Cache some directories

ErikSchierboom
ErikSchierboom approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devkabiir
devkabiir approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@devkabiir devkabiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🚀

.github/workflows/test.yml Outdated Show resolved Hide resolved
@devkabiir devkabiir added the hacktoberfest-accepted Hacktoberfest accepted PR label Oct 22, 2020
@devkabiir
Copy link
Contributor

@ErikSchierboom It looks like something's wrong with either travis or GHA. Do you know anything about this? I can't see the new GHA kicking-in in this PR and merging is blocked by travis.

@ErikSchierboom
Copy link
Member

Hmmm, looks like it still considers Travis to be required. @iHiD could you merge this?

@cmccandless
Copy link

Two issues going on here:

  • GHA won't run workflows from forks that don't exist yet in the base repository. I suggest opening a new PR to test after this has been merged.
  • Travis is still set required; only an admin can disable it as a required check (@iHiD, I know you were pinged above but maybe this got lost in the shuffle?)

@iHiD
Copy link
Member

iHiD commented Nov 25, 2020

Should be mergable now. I also need to turn on the GHA check once this is merged. Please remind me.

@iHiD iHiD merged commit 5a4b784 into exercism:master Nov 25, 2020
@Stargator
Copy link
Contributor

@davidlutta Thanks for your work. Would you be interested in updating the workflow to include builds for the latest stable version of Dart and the dev version?

That helps us catch any breaking changes that might be coming down the pipe. I can create an issue for it, if you'd like

@davidlutta
Copy link
Contributor Author

@Stargator Yeah sure I'd like to have a go on it.

@Stargator
Copy link
Contributor

@davidlutta You can find the issue at #270

@Stargator Stargator added this to the 2020 Improve Tests or CI milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkabiir devkabiir devkabiir approved these changes

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees

@davidlutta davidlutta

Labels
enhancement hacktoberfest-accepted Hacktoberfest accepted PR
Projects
None yet
Milestone
2020 Improve Tests or CI
Development

Successfully merging this pull request may close these issues.

Moving from Travis to GitHub Actions
6 participants
@davidlutta @devkabiir @ErikSchierboom @cmccandless @iHiD @Stargator