Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions.md #2128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update instructions.md #2128

wants to merge 1 commit into from

Conversation

jxbrenner
Copy link

Speed is distance per unit time, updated all references to speed units of meters to meters per second

Speed is distance per unit time, updated all references to speed units of meters to meters per second
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 5, 2023
@ErikSchierboom ErikSchierboom reopened this May 5, 2023
@@ -2,7 +2,7 @@

In this exercise you'll be organizing races between various types of remote controlled cars. Each car has its own speed and battery drain characteristics.

Cars start with full (100%) batteries. Each time you drive the car using the remote control, it covers the car's speed in meters and decreases the remaining battery percentage by its battery drain.
Cars start with full (100%) batteries. Each time you drive the car using the remote control, it increases the car's speed in meters per second and decreases the remaining battery percentage by its battery drain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this reads as: the speed is increased, which it isn't. I like the other two suggestions, but maybe change or revert this?

Copy link
Author

@jxbrenner jxbrenner May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, increases the speed doesn't make sense if the car is already travelling. How about, "it causes the car to travel at its rated speed for 1 second and decreases the remaining battery percentage by its battery drain rate."? It's wordier but I think it helps lead the reader to distanceTravelled = speed * time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no time in this exercise, the speed is in distance per click of a button, not per unit of time.
How about

"Every time you drive the car using the remote control, the car travels distance equal to its current speed and its battery level drop by the the value of battery drain." Or something like this?

Copy link
Author

@jxbrenner jxbrenner May 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distance per press of a button is just distance. But the exercise is full of references to speed, and anywhere you talk about speed, you infer time by the definition of speed. My suggestion is either:

  • replace all references to speed to distance travelled per use of the remote control, or
  • define the amount of time the car travels at rated speed per use of the remote control so you have the information you need to convert rated speed to distance travelled, ex. _totalDistance += _speed * 1; if the operating the remote control causes the car to travel at its rated speed for 1 second

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time you drive the car using the remote control, the car travels distance equal to its current speed and its battery level drop by the the value of battery drain

I like this suggestion.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time you drive the car using the remote control, the car travels distance equal to its current speed and its battery level drop by the the value of battery drain

I like this suggestion.

"travels distance equal to its current speed" makes no sense, speed does not equal distance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants