Add getters and setters concept and exercise #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanplusplus
requested changes
Aug 17, 2024
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "blurb": "Crystal has macros for defining getters and setters. Which is used to access and modify the instance variables of a class.", | |||
There was a problem hiding this comment.
Suggested change
| "blurb": "Crystal has macros for defining getters and setters. Which is used to access and modify the instance variables of a class.", | |
| "blurb": "Crystal has macros for defining getters and setters. These are used to access and modify the instance variables of a class.", |
concepts/getters-setters/about.md
Outdated
| Getter is a macro that defines a method that returns the value of an instance variable. | ||
| This means that you no longer have to write `@` in front of the instance variable when you want to access it (in methods, excluding initialize); instead, you can call the method that the getter macro has defined. | ||
|
|
||
| The getter macro can accept multiple instance variables by separating them with a comma. |
There was a problem hiding this comment.
Suggested change
| The getter macro can accept multiple instance variables by separating them with a comma. | |
| The getter macro can accept multiple instance variables by separating them with commas. |
concepts/getters-setters/about.md
Outdated
|
|
||
| ## Setters | ||
|
|
||
| Setters is a macro that defines a method that sets the value of an instance variable. |
There was a problem hiding this comment.
Suggested change
| Setters is a macro that defines a method that sets the value of an instance variable. | |
| Setter is a macro that defines a method that sets the value of an instance variable. |
| 1 + yield(2, 3) | ||
| end | ||
|
|
||
| p my_method { |x, y| x * y } |
There was a problem hiding this comment.
Suggested change
| p my_method { |x, y| x * y } | |
| p my_method { |x, y| x * y } | |
Comment on lines
2
to
3
| 1 + yield(2, 3) | ||
| end |
There was a problem hiding this comment.
Suggested change
| 1 + yield(2, 3) | |
| end | |
| 1 + yield(2, 3) | |
| end |
| @@ -0,0 +1,63 @@ | |||
| # Instructions | |||
|
|
|||
| In this exercise you'll be modelling a weighing machine. | |||
There was a problem hiding this comment.
Suggested change
| In this exercise you'll be modelling a weighing machine. | |
| In this exercise you'll be modeling a weighing machine. |
|
|
||
| Implement the `WeighingMachine#initialize` method which takes two arguments, `precision` which is an `Int32` and `metric` which is a `Bool`. | ||
| The `metric` argument when `true` means that the machine should use the metric system, otherwise it should use the imperial system. | ||
| The initizalized set should also set an instance variable, `@weight` to `0.0`. |
There was a problem hiding this comment.
Suggested change
| The initizalized set should also set an instance variable, `@weight` to `0.0`. | |
| The initialize method set should also set the instance variable `@weight` to `0.0`. |
|
|
||
| ## 4. Allow the machine to be switch between metric and imperial units | ||
|
|
||
| Implement the `WeighingMachine#metric=` property to allow the unit to be set, it should accept a boolean value. |
There was a problem hiding this comment.
Suggested change
| Implement the `WeighingMachine#metric=` property to allow the unit to be set, it should accept a boolean value. | |
| Implement the `WeighingMachine#metric=` property to allow the unit to be set. | |
| It should accept a boolean value. |
| weighing_machine.precision.should eq(5) | ||
| end | ||
|
|
||
| it "should not allowed to be modify" do |
There was a problem hiding this comment.
Suggested change
| it "should not allowed to be modify" do | |
| it "should not allow modification" do |
| weighing_machine.weigh.should eq("11.023") | ||
| end | ||
|
|
||
| it "should not allowed to be get" do |
There was a problem hiding this comment.
Suggested change
| it "should not allowed to be get" do | |
| it "should not allow getting" do |
ryanplusplus
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the last concept for a while to be added