Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create, fmt, info: remove unused imports #825

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 6, 2023

With this PR, there is exactly one file (helpers.nim) that imports jsony, and it also exports jsony. Following this rule should make the codebase more robust to the problem of parseHooks not being visible.

To-do:

  • Add some of these back, if they were actually used.

@ee7 ee7 requested a review from ErikSchierboom October 6, 2023 07:23
@ee7 ee7 force-pushed the remove-unused-imports branch from b14f395 to 3eefad8 Compare October 6, 2023 07:29
@ee7 ee7 marked this pull request as ready for review October 6, 2023 07:29
@ee7 ee7 merged commit 77fd69e into exercism:main Oct 6, 2023
@ee7 ee7 deleted the remove-unused-imports branch October 6, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants