Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-configlet.ps1: fails in CI #786

Closed
ee7 opened this issue Aug 13, 2023 · 1 comment · Fixed by #787
Closed

fetch-configlet.ps1: fails in CI #786

ee7 opened this issue Aug 13, 2023 · 1 comment · Fixed by #787
Assignees
@ErikSchierboom

Comments

@ee7
Copy link
Member

ee7 commented Aug 13, 2023

Unless this is some transient error, it looks like the fetch-configlet PowerShell script now fails in CI:

Invoke-WebRequest: D:\a\configlet\configlet\scripts\fetch-configlet.ps1:29
Line |
  29 |  Invoke-WebRequest -Uri $downloadUrl -OutFile $outputFile @requestOpts
     |                         ~~~~~~~~~~~~
     | Cannot convert 'System.Object[]' to the type 'System.Uri' required by parameter 'Uri'. Specified method is not
     | supported.

Error: Process completed with exit code 1.

The workflow pins the version of Windows:

configlet/.github/workflows/fetch-configlet.yml

Line 25 in 5e6ddd8

runs-on: windows-2022

but does not pin the version of PowerShell.

The job was successful with image version 20230730.1 but fails with image version 20230804.1.1
ee7 added a commit to ee7/exercism-configlet that referenced this issue Aug 13, 2023
@ee7
empty commit
ab0548d 
I tested the previous commit by tagging it, and pushing that tag to
exercism/configlet, which triggers the build workflow.

But it looks like it also triggered the fetch-configlet workflow, which
seems to fail on Windows [1]. Create an empty commit so that there's no
failing fetch-configlet check on the pull request.

[1] exercism#786
@ErikSchierboom ErikSchierboom mentioned this issue Aug 14, 2023
Merged
@ErikSchierboom
Copy link
Member

Fixed in #787

@ee7 ee7 closed this as completed in #787 Aug 14, 2023
ee7 pushed a commit that referenced this issue Aug 14, 2023
@ErikSchierboom
fetch-configlet: fix download in PowerShell script (#787)
6123274 
Fixes: #786
@ee7 ee7 mentioned this issue Nov 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikSchierboom ErikSchierboom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fetch-configlet: fix download in PowerShell script exercism/configlet
2 participants
@ErikSchierboom @ee7