Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the switch to implementing own stubs easier #255

Merged
merged 8 commits into from
Jan 8, 2018
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
124 changes: 124 additions & 0 deletions exercises/gigasecond/.meta/hints.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
## Exercises without stub implementations

Like the majority of C programs you will write, this exercise comes without any header file (`*.h`) or source file (`*.c`).


### Add the required files

You will need to create these yourself as part of the exercise.
This is so that you get to practice deciding on and creating the program's interface yourself, which is an important part of programming in C.
It does mean that when you first try to run the tests, they won't compile.
They will give you an error similar to:

```bash
make: *** No rule to make target 'src/exercise_name.c', needed by 'tests.out'. Stop.
```

This error occurs because the `makefile` attempts to use a file that hasn't been created yet (`exercise_name.c`).
To resolve this error you will need to add a matching file to the `src` directory.
For example, for the error above you would add a file called `exercise_name.c`.

When you try to run the tests again you will get a slightly different error.

```bash
make: *** No rule to make target 'src/exercise_name.h', needed by 'tests.out'. Stop.
```

Again the `makefile` still needs another file that has yet to be created (`exercise_name.h`).
The solution to this error is similar to the last, add the matching file to the `src` directory.
For example, for the above error you would add a file called `exercise_name.h`


### Add the required declarations

Running the tests a third time you see you will get new errors, similar to:

```bash
Compiling tests.out
src/exercise_name.c:1:0: error: ISO C forbids an empty translation unit [-Werror=pedantic]
cc1: all warnings being treated as errors
test/test_exercise_name.c:13:1: error: unknown type name ‘bar_t’; did you mean ‘__bar_t’?
bar_t b = foo(a, 2.5);
^~~~~~
__bar_t
test/test_exercise_name.c:15:14: error: storage size of fizz isn’t known
struct baz fizz;
^~~~
test/test_exercise_name.c:29:20: error: implicit declaration of function ‘foo’ [-Werror=implicit-function-declaration]
bar_t b = foo_function(fizz, 2.5);
```

This error means that you need to add function, type and variable decarations to the header file to match those the test file is attempting to use.
In doing this you will need to look at the build errors and the test code to determine what needs to be declared in the header file.

For example, for the error above you should declare a type named `bar_t`, a `struct` called `baz` and a function named `foo()`.
Additionally we can tell from looking at the above errors that function `foo()` has two parameters.

The first parameter is passed an argument of `fizz` and thus should have a type of `struct baz`.
The second parameter is passed `2.5` and so could have one of two types, either `float` or `double`.
You will need to look at the test code to determine which.

The _names_ of the parameters are not determined by the test code and so are left up to you to decide, though in keeping with C programming practices they should be descriptive but not overly long.

Further, we can see that the the return type expected by the test code is of the type `bar_t`.

Putting this all together we end up with a function declaration that looks like the following:

```c
// The parameter names are not very good here they should be more descriptive in a real exercise.
// We have decide on a double for the second parameter in this hypothetical example.
bar_t foo(struct baz b, double d);
```

You should continue to do this for any further similar errors.
To check that you have correctly determined the required declaration, just run the tests again and analyse any errors similarly.

Additionally, remember to add any includes to the header file any headers that it itself requires.


### Include guards

Before you are finished with the header file, you should add include guards.
Include guards are used to help prevent the file from being included multiple times by accident.
If the file _was_ included multiple times then the functions and other items would be declared twice; In C this is an error because the compiler thinks you are trying to declare another _different_ function that has the same name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ; could probably just be a ., but I tried to take only a half step away from the em dash.


To add include guards, add something similar to the following as the first two lines of the header:

```c
#ifndef EXERCISE_NAME_H
#define EXERCISE_NAME_H
```

And on the very last line:

```c
#endif
```


### Add the required definitions

Once the header file is complete you may still have build errors similar to the following:

```bash
Compiling tests.out
src/exercise_name.c:1:0: error: ISO C forbids an empty translation unit [-Werror=pedantic]
cc1: all warnings being treated as errors
makefile:24: recipe for target 'tests.out' failed
make: *** [tests.out] Error 1
```

This is because although you have _declared_ all the items you need to, they have not yet been _defined_.
To define the needed items you need to add their implementation to the `exercise_name.c` file.
For the function `foo()` from the previous example, this would look similar to:

```c
#include "exercise_name.h"

bar_t foo(struct baz b, double d)
{
// Your exercise code here
}
```

After having resolved these errors you should be ready to start making the tests pass!
121 changes: 121 additions & 0 deletions exercises/gigasecond/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,127 @@ Calculate the moment when someone has lived for 10^9 seconds.

A gigasecond is 10^9 (1,000,000,000) seconds.

## Exercises without stub implementations

Like the majority of C programs you will write, this exercise comes without any header file (`*.h`) or source file (`*.c`).


### Add the required files

You will need to create these yourself as part of the exercise.
This is so that you get to practice deciding on and creating the program's interface yourself, which is an important part of programming in C.
It does mean that when you first try to run the tests, they won't compile. They will give you an error similar to:

```bash
make: *** No rule to make target 'src/exercise_name.c', needed by 'tests.out'. Stop.
```

This error occurs because the `makefile` attempts to use a file that hasn't been created yet (`exercise_name.c`).
To resove this error you will need to add a matching file to the `src` directory.
For example, for the error above you would add a file called `exercise_name.c`.

When you try to run the tests again you will get a slightly different error.

```bash
make: *** No rule to make target 'src/exercise_name.h', needed by 'tests.out'. Stop.
```

Again the `makefile` still needs another file that has yet to be created (`exercise_name.h`).
The solution to this error is similar to the last, add the matching file to the `src` directory.
For example, for the above error you would add a file called `exercise_name.h`


### Add the required declarations

Running the tests a third time you see you will get new errors, similar to:

```bash
Compiling tests.out
src/exercise_name.c:1:0: error: ISO C forbids an empty translation unit [-Werror=pedantic]
cc1: all warnings being treated as errors
test/test_exercise_name.c:13:1: error: unknown type name ‘bar_t’; did you mean ‘__bar_t’?
bar_t b = foo(a, 2.5);
^~~~~~
__bar_t
test/test_exercise_name.c:15:14: error: storage size of fizz isn’t known
struct baz fizz;
^~~~
test/test_exercise_name.c:29:20: error: implicit declaration of function ‘foo’ [-Werror=implicit-function-declaration]
bar_t b = foo_function(fizz, 2.5);
```

This error means that you need to add function, type and variable decarations to the header file to match those the test file is attempting to use.
In doing this you will need to look at the build errors and the test code to determine what needs to be declared in the header file.

For example, for the error above you should declare a type named `bar_t`, a `struct` called `baz` and a function named `foo()`.
Additionally we can tell from looking at the above errors that function `foo()` has two parameters.

The first parameter is passed an argument of `fizz` and thus should have a type of `struct baz`.
The second parameter is passed `2.5` and so could have one of two types, either `float` or `double`, you will need to look at the test code to determine which.

The _names_ of the parameters are not determined by the test code and so are left up to you to decide, though in keeping with C programming practices they should be descriptive but not overly long.

Further, we can see that the the return type expected by the test code is of the type `bar_t`.

Putting this all together we end up with a function declaration that looks like the following:

```c
// The parameter names are not very good here they should be more descriptive in a real exercise.
// We have decide on a double for the second parameter in this hypothetical example.
bar_t foo(struct baz b, double d);
```

You should continue to do this for any further similar errors.
To check that you have correctly determined the required declaration, just run the tests again and analyse any errors similarly.

Additionally, remember to add any includes to the header file any headers that it itself requires.


### Include guards
Before you are finished with the header file, you should add include uards.
Include guards are used to help prevent the file from being included multiple times by accident.
If the file _was_ included multiple times then the functions and other items would be declared twice - In C this is an error because the compiler thinks you are trying to declare another _different_ function that has the same name.

To add include guards, add something similar to the following as the first two lines of the header:

```c
#ifndef EXERCISE_NAME_H
#define EXERCISE_NAME_H
```

And on the very last line:

```c
#endif
```


### Add the required definitions

Once the header file is complete you ay still have build errors similar to the following:

```bash
Compiling tests.out
src/exercise_name.c:1:0: error: ISO C forbids an empty translation unit [-Werror=pedantic]
cc1: all warnings being treated as errors
makefile:24: recipe for target 'tests.out' failed
make: *** [tests.out] Error 1
```

This is because although you have _declared_ all the items you need to, they have not yet been _defined_.
To define the needed items you need to add thier implementation to the `exercise_name.c` file.
For the function `foo()` from the previous example, this would look similar to:

```c
#include "exercise_name.h"

bar_t foo(struct baz b, double d)
{
// Your exercise code here
}
```
After having resolved these errors you should be ready to start making the tests pass!

## Getting Started

Make sure you have read the
Expand Down
File renamed without changes.
File renamed without changes.