Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new exercise - series #25

Merged
merged 3 commits into from
Apr 9, 2024
Merged

new exercise - series #25

merged 3 commits into from
Apr 9, 2024

Conversation

GroophyLifefor
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 6, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@GroophyLifefor
Copy link
Member Author

[no important files changed]

@GroophyLifefor
Copy link
Member Author

it seems to be triggered because I edited the test file of another exercise, if you look at the changes I edited a simple comment line, there is no problem

@ErikSchierboom
Copy link
Member

it seems to be triggered because I edited the test file of another exercise, if you look at the changes I edited a simple comment line, there is no problem

Just to be clear what the above message means. If this PR is merged, the fact that a test file was updated would mean all of its solutions would have to be rerun in the test runner. Whilst the track is currently not yet live, this doesn't yet matter, but it will be important once it is live. The fact that it is "just a comment" is not something we can detect, so we'd have to rerun the solutions. However, you, the maintainer, can identify that it is "just a comment", in which case rerunning the tests wouldn't change any outcome. If this is true, you should add the [no important files changed] text to the commit message (you can add it when you get the commit text after pressing on Squash and merge).

See https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs for more information.

@GroophyLifefor
Copy link
Member Author

it seems to be triggered because I edited the test file of another exercise, if you look at the changes I edited a simple comment line, there is no problem

Just to be clear what the above message means. If this PR is merged, the fact that a test file was updated would mean all of its solutions would have to be rerun in the test runner. Whilst the track is currently not yet live, this doesn't yet matter, but it will be important once it is live. The fact that it is "just a comment" is not something we can detect, so we'd have to rerun the solutions. However, you, the maintainer, can identify that it is "just a comment", in which case rerunning the tests wouldn't change any outcome. If this is true, you should add the [no important files changed] text to the commit message (you can add it when you get the commit text after pressing on Squash and merge).

See https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs for more information.

Thanks you so much, I got it.

@GroophyLifefor GroophyLifefor merged commit e9ec01c into main Apr 9, 2024
1 check passed
@GroophyLifefor GroophyLifefor deleted the exercise/series branch April 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants