Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints not appearing #123

Closed
pokrakam opened this issue Apr 3, 2022 · 6 comments · Fixed by #128
Closed

Hints not appearing #123

pokrakam opened this issue Apr 3, 2022 · 6 comments · Fixed by #128

Comments

@pokrakam
Copy link
Collaborator

pokrakam commented Apr 3, 2022

Question for the Exercism folk - @ErikSchierboom can you help?
I added a hints file but it is not appearing in the exercise.
https://github.com/exercism/abap/blob/main/exercises/practice/custom-signs/.docs/hints.md

I copied the JS one and rewrote the content, figuring if I start from a working example it should be OK.

It's the first hints file on the track, so am wondering if there is a config.json setting or something? Didn't see anything in the JS track or in the contributor documentation.

@ErikSchierboom
Copy link
Member

This is because the original exercise was a concept exercise but it is ported to a practice exercise. Practice exercises can't (yet) have tasks, but the hints are all linked to specific tasks. You can "fix" this by moving all the hints in a ## General heading.

This is one of the reasons why I'd suggest not to port concept exercises to practice exercises, but instead use on the practice exercises defined at https://github.com/exercism/problem-specifications/tree/main/exercises.

@pokrakam pokrakam mentioned this issue Apr 5, 2022
@pokrakam
Copy link
Collaborator Author

pokrakam commented Apr 5, 2022

Thanks, could you please check if PR #128 is what you mean? I did see a reference to ## General in the docs and was a little confused why it didn't appear in the JS version. Unfortunately we can't test this without merging.

pokrakam added a commit that referenced this issue Apr 5, 2022
@pokrakam pokrakam reopened this Apr 5, 2022
@pokrakam
Copy link
Collaborator Author

pokrakam commented Apr 5, 2022

Hmm, still not showing up. Trying without subheadings.

@pokrakam
Copy link
Collaborator Author

pokrakam commented Apr 5, 2022

OK, had another go with PR #129 and it is still not showing any hints.
What is wrong with https://github.com/exercism/abap/blob/main/exercises/practice/custom-signs/.docs/hints.md ?
(apart from one small typo which I'll fix in the next iteration)

@pokrakam
Copy link
Collaborator Author

pokrakam commented Apr 5, 2022

Ah, never mind, you need to update the exercise to get the hints to appear. They're working now!
image

@pokrakam pokrakam closed this as completed Apr 5, 2022
@ErikSchierboom
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants