-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Translation support in GitHub Actions #684
Conversation
@choldgraf it seems I can only translate to 9 languages from smodin. Do you have a premium account? As it seems other words have translations in more languages. |
Let's just go with the 9 languages - this is just a start anyway, I think that it will likely require manual updates for many languages anyway since automatic translating is likely to some things slightly incorrectly |
ooh okay cool. I reckon we need to find words manually of what we want to update. Some words already found are:- |
Yeah that makes sense - we can do the best we can now, and if we miss something we can always improve it in a future PR ! |
By the way, do you know how to handle translation strings when there is a word that isn't supposed to be translated? Eg "edit on GitHub" - we want "GitHub" to be part of the phrase (so that for example German speakers see it at the beginning of the phrase instead of the end), but it isn't translatable. I think there are guidelines for how to handle this but I don't know what they are. Ah i just remembered this PR might have some recommendations (though it uses gettext directly rather than our middle-layer custom translation stuff) |
By the way, |
Ah nice - so we don't need to change anything for now? If that's the case I think we should just merge this and cut a release candidate |
Seems like it. But I don't know why it was not working in the first place. Because of lack of |
Yes without those files present sphinx |
_compile_translations.py
, so that .mo files are present in build folderfixes #584