Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ IMPROVE: Improving accessibility labeling #375

Merged
merged 1 commit into from
Aug 16, 2021
Merged

✨ IMPROVE: Improving accessibility labeling #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx_book_theme/_templates/sbt-sidebar-nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<nav class="bd-links" id="bd-docs-nav" aria-label="Main navigation">
<nav class="bd-links" id="bd-docs-nav" aria-label="Main">
<div class="bd-toc-item active">
{{ sbt_generate_nav_html(include_item_names=True, with_home_page=theme_home_page_in_toc, show_depth=theme_show_navbar_depth) }}
</div>
Expand Down
2 changes: 1 addition & 1 deletion sphinx_book_theme/topbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<div class="tocsection onthispage pt-5 pb-3">
<i class="fas fa-list"></i> {{ translate(theme_toc_title) }}
</div>
<nav id="bd-toc-nav">
<nav id="bd-toc-nav" aria-label="Page">
{{ page_toc }}
</nav>
{%- endif %}
Expand Down
2 changes: 1 addition & 1 deletion tests/test_build/page-multipletitles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</i>
Contents
</div>
<nav id="bd-toc-nav">
<nav aria-label="Page" id="bd-toc-nav">
<ul class="visible nav section-nav flex-column">
<li class="toc-h1 nav-item toc-entry">
<a class="reference internal nav-link" href="#">
Expand Down
2 changes: 1 addition & 1 deletion tests/test_build/page-onetitle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</i>
Contents
</div>
<nav id="bd-toc-nav">
<nav aria-label="Page" id="bd-toc-nav">
<ul class="visible nav section-nav flex-column">
<li class="toc-h2 nav-item toc-entry">
<a class="reference internal nav-link" href="#here-s-a-sub-heading">
Expand Down
2 changes: 1 addition & 1 deletion tests/test_build/test_build_book.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ <h1 class="site-logo" id="site-title">
</i>
<input aria-label="Search the docs ..." autocomplete="off" class="form-control" id="search-input" name="q" placeholder="Search the docs ..." type="search"/>
</form>
<nav aria-label="Main navigation" class="bd-links" id="bd-docs-nav">
<nav aria-label="Main" class="bd-links" id="bd-docs-nav">
<div class="bd-toc-item active">
<p class="caption">
<span class="caption-text">
Expand Down