👌 NEW: Added tag for cell-input #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me! Wanna add some docs here and then we can tackle a PR in JB? |
|
@choldgraf sorry did not get you? Add docs in |
|
Yep we should document in both places, since people may use this theme independent of jupyter book |
|
@choldgraf same goes for |
|
Yeah as a general rule we document everything in both spots. Longer term we could think of ways to streamline the docs but for now I think we should make sure the information is in both spots |
|
@choldgraf have finally added the docs 😅 . What do you think? |
|
sorry for the slow turnaround on this - but this looks great @AakashGfude , thanks for the improvement 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @mmcky , we should also enable input tags to have a fixed height and scrollable, using tags.
With this PR,
will work the same for input cells, as scroll-output was working for output cells.
If this sounds like a good addition, then we can go ahead and add it to jb docs like in this PR: https://github.com/executablebooks/jupyter-book/pull/1075/files. (although I think that these tags should be in sphinx-book-theme docs)