Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Centralise code block test #83

Merged
merged 1 commit into from
Jun 3, 2023
Merged

👌 Centralise code block test #83

merged 1 commit into from
Jun 3, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jun 3, 2023

All block level rules first test whether the first character is indented enough to be a code block. This logic is centralised, and allows for the StateBlock.is_code_block method, coming in markdown-it-py v3.0.0

All block level rules first test whether the firs character is indented enough to be a code block.
This logic is centralised, and allows for the `StateBlock.is_code_block` method, coming in markdown-it-py v3.0.0
@chrisjsewell chrisjsewell merged commit 85f7ed3 into master Jun 3, 2023
@chrisjsewell chrisjsewell deleted the code-block branch June 3, 2023 06:10
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: -0.12 ⚠️

Comparison is base (875bbe5) 92.92% compared to head (7a391e9) 92.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   92.92%   92.80%   -0.12%     
==========================================
  Files          30       31       +1     
  Lines        1752     1779      +27     
==========================================
+ Hits         1628     1651      +23     
- Misses        124      128       +4     
Flag Coverage Δ
pytests 92.80% <78.26%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdit_py_plugins/myst_blocks/index.py 95.60% <57.14%> (+0.04%) ⬆️
mdit_py_plugins/admon/index.py 96.42% <66.66%> (-0.82%) ⬇️
mdit_py_plugins/deflist/index.py 94.36% <66.66%> (-0.60%) ⬇️
mdit_py_plugins/dollarmath/index.py 91.12% <66.66%> (+0.05%) ⬆️
mdit_py_plugins/footnote/index.py 94.84% <66.66%> (-0.34%) ⬇️
mdit_py_plugins/substitution.py 88.05% <66.66%> (+0.18%) ⬆️
mdit_py_plugins/colon_fence.py 96.87% <75.00%> (+0.04%) ⬆️
mdit_py_plugins/container/index.py 96.90% <75.00%> (-0.97%) ⬇️
mdit_py_plugins/amsmath/__init__.py 95.74% <100.00%> (+0.09%) ⬆️
mdit_py_plugins/attrs/index.py 92.17% <100.00%> (+0.06%) ⬆️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

chrisjsewell added a commit that referenced this pull request Jun 5, 2023
chrisjsewell added a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant