Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Parsing when newline is between footnote ID and first paragraph #49

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Aug 8, 2022

Closes #48

This merely fixes a porting issue -- Javascript upstream already works like this.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #49 (22d07e5) into master (d627eac) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files          25       25           
  Lines        1351     1351           
=======================================
  Hits         1259     1259           
  Misses         92       92           
Flag Coverage Δ
pytests 93.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdit_py_plugins/footnote/index.py 95.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nschloe
Copy link

nschloe commented Aug 25, 2022

I can confirm that this fixes the issue. Merging + releasing would be helpful for me.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@chrisjsewell chrisjsewell merged commit 855067e into executablebooks:master Aug 25, 2022
@hukkin hukkin deleted the issue-48 branch August 25, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footnote with blank first line
3 participants